Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvpn3] Update, adapt upstream build, cleanup, test #40677

Merged
merged 5 commits into from
Sep 3, 2024
Merged

[openvpn3] Update, adapt upstream build, cleanup, test #40677

merged 5 commits into from
Sep 3, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Aug 28, 2024 •
edited
Loading

Resolves #28861.
Removes one blocker for mbedtls update (#40687, PRs, issues).

FTR upstream's default choice is openssl instead of mbedtls. This PR keeps vcpkg's choice for now.

@dg0yt dg0yt mentioned this pull request Aug 28, 2024
Closed
@MonicaLiu0311 MonicaLiu0311 self-requested a review August 28, 2024 10:26
@MonicaLiu0311 MonicaLiu0311 self-assigned this Aug 28, 2024
@MonicaLiu0311 MonicaLiu0311 added category:port-update The issue is with a library, which is requesting update new revision category:port-bug The issue is with a library, which is something the port should already support labels Aug 28, 2024
@dg0yt dg0yt marked this pull request as draft August 28, 2024 15:22
@dg0yt dg0yt marked this pull request as ready for review August 28, 2024 16:13
@dg0yt
Copy link
Contributor Author

dg0yt commented Aug 29, 2024

You can review as is, but uwp still needs more work (tested in #40687).

@dg0yt dg0yt mentioned this pull request Aug 29, 2024
Draft
11 tasks
@dg0yt
Copy link
Contributor Author

dg0yt commented Aug 29, 2024

uwp is blocked by OpenVPN/openvpn3#326.

@dg0yt dg0yt mentioned this pull request Aug 29, 2024
Merged
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 30, 2024
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

openvpn3 provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(unofficial-openvpn3 CONFIG REQUIRED)
  target_link_libraries(main PRIVATE unofficial::openvpn3::ovpncli)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 30, 2024
@vicroms vicroms merged commit 401175d into microsoft:master Sep 3, 2024
16 checks passed
@dg0yt dg0yt deleted the openvpn3 branch September 4, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openvpn3] openvpn3 should use the upstreams CMakeLists.txt
3 participants
@dg0yt @MonicaLiu0311 @vicroms